## Crafting a Quality PR

A strong MinIO PR:
- Delivers a complete, valuable change (feature, bug fix, or improvement).
- Has a concise title (e.g., `[S3] Fix bucket policy parsing #1234`) and a summary with context, referencing issues (e.g., `#1234`).
- Contains well-written, logical commits explaining *why* changes were made (e.g., “Add S3 bucket tagging support so that users can organize resources efficiently”).

    -   id: check-toml
    -   id: check-yaml
        args:
        -   --unsafe
    -   id: end-of-file-fixer
    -   id: trailing-whitespace
-   repo: https://github.com/astral-sh/ruff-pre-commit
    rev: v0.12.10
    hooks:
    -   id: ruff
        args:
        - --fix
    -   id: ruff-format
ci:
    autofix_commit_msg: 🎨 [pre-commit.ci] Auto format from pre-commit.com hooks

* For issues with Docker 1.13.X please see the [1.13.X tracking issue](https://github.com/kubernetes/kubernetes/issues/42926)

* rkt version 1.23.0+

    * known issues with the rkt runtime are [listed in the Getting Started Guide](https://kubernetes.io/docs/getting-started-guides/rkt/notes/)

* etcd version 3.0.17

  really needed (ASCII art, table, or long link)
+ If there is a corresponding issue, add either `Fixes #1234` or `Updates #1234`
  (the latter if this is not a complete fix) to this comment
+ If referring to a repo other than `golang/go` you can use the
  `owner/repo#issue_number` syntax: `Fixes golang/tools#1234`
+ We do not use Signed-off-by lines in Go. Please don't add them.

    assertThat(
      inet4AddressToAscii(
        byteArrayOf(0, 0, 0, 0),
      ),
    ).isEqualTo("0.0.0.0")

    assertThat(
      inet4AddressToAscii(
        byteArrayOf(1, 2, 3, 4),
      ),
    ).isEqualTo("1.2.3.4")

    assertThat(
      inet4AddressToAscii(
        byteArrayOf(127, 0, 0, 1),
      ),
    ).isEqualTo("127.0.0.1")

    assertThat(
      inet4AddressToAscii(

        bufferIndex += 4; // 2 reserved
        this.dataLength = SMBUtil.readInt2(buffer, bufferIndex);
        bufferIndex += 2;
        this.dataOffset = SMBUtil.readInt2(buffer, bufferIndex);
        bufferIndex += 12; // 10 reserved

        return bufferIndex - start;
    }

    @Override
    protected int readBytesWireFormat(final byte[] buffer, final int bufferIndex) {
        // handled special in SmbTransport.doRecv()

        // Arrange
        Smb2LogoffRequest req = newRequest();

        // Act
        int resultWithNull = req.readBytesWireFormat(null, 0);
        int resultWithData = req.readBytesWireFormat(new byte[] { 1, 2, 3 }, 1);

        // Assert
        assertEquals(0, resultWithNull, "Should return 0 for null buffer");
        assertEquals(0, resultWithData, "Should return 0 regardless of input data");
    }

    @Nested

kill $pid

(minio server http://localhost:9000/tmp/xl/{1...10}/disk{0...1} http://localhost:9001/tmp/xl/{11...30}/disk{0...3} 2>&1 >/tmp/expanded_1.log) &
pid_1=$!

(minio server --address ":9001" http://localhost:9000/tmp/xl/{1...10}/disk{0...1} http://localhost:9001/tmp/xl/{11...30}/disk{0...3} 2>&1 >/tmp/expanded_2.log) &
pid_2=$!

./mc ready myminio

expanded_user_count=$(./mc admin user list myminio/ | wc -l)

          k2 ^= (long) toUnsignedInt(bb.get(14)) << 48; // fall through
        case 14:
          k2 ^= (long) toUnsignedInt(bb.get(13)) << 40; // fall through
        case 13:
          k2 ^= (long) toUnsignedInt(bb.get(12)) << 32; // fall through
        case 12:
          k2 ^= (long) toUnsignedInt(bb.get(11)) << 24; // fall through
        case 11:
          k2 ^= (long) toUnsignedInt(bb.get(10)) << 16; // fall through
        case 10:

        final SQLRuntimeException sqlRuntimeException = new SQLRuntimeException(sqlException);

        // ## Act ##
        final String message = sqlRuntimeException.getMessage();

        // ## Assert ##
        System.out.println(message);
        assertContains(message, "ErrorCode=1234");
        assertContains(message, "SQLState=barState");