## Pull Request 리뷰하기 { #review-pull-requests }

다른 사람들이 만든 pull request를 리뷰하는 데 저를 도와줄 수 있습니다.

다시 한번 말하지만, 최대한 친절하게 리뷰해 주세요. 🤗

---

Pull request를 리뷰할 때 고려해야 할 사항과 방법은 다음과 같습니다:

### 문제 이해하기 { #understand-the-problem }

* 먼저, 해당 pull request가 해결하려는 **문제를 이해하는지** 확인하세요. GitHub Discussion 또는 이슈에서 더 긴 논의가 있었을 수도 있습니다.

	// execute the HTTP request for object upload.
	response, err = s.client.Do(request)
	c.Assert(err, nil)
	c.Assert(response.StatusCode, http.StatusOK)

	objectName2 := "testObject2"
	// Unlike the actual PUT object request, the request to Copy Object doesn't contain request body,
	// empty body with the "X-Amz-Copy-Source" header pointing to the object to copies it in the backend.

        override fun writeTo(sink: BufferedSink) {
          sink.writeUtf8("Hello request!")
          sink.close()
        }

        override fun isDuplex(): Boolean = true
      }
    val request =
      request()
        .post(asyncRequestBody)
        .build()
    val response = client.newCall(request).execute()
    Assumptions.assumeTrue(response.protocol == Protocol.HTTP_2)

    assertThat(testFuture.toString())
        .matches("[^\\[]+\\[status=SUCCESS, result=\\[java.lang.Boolean@\\w+\\]\\]");
  }

  /**
   * This test attempts to cause a future to wait for longer than it was requested to from a timed
   * get() call. As measurements of time are prone to flakiness, it tries to assert based on ranges
   * derived from observing how much time actually passed for various operations.
   */

        int counter2 = buffer2.getInt();

        assertEquals(counter1 + 1, counter2, "Counter should increment between nonces");
    }

    @Test
    @DisplayName("Should generate secure random nonces when requested")
    void testSecureNonceGeneration() {
        // Given
        Smb2EncryptionContext context = new Smb2EncryptionContext(EncryptionNegotiateContext.CIPHER_AES128_GCM, DialectVersion.SMB311,

        // in.available() always returns 0 (the default).
        int skip = (int) min(remaining, BUFFER_SIZE);
        if (buf == null) {
          // Allocate a buffer bounded by the maximum size that can be requested, for
          // example an array of BUFFER_SIZE is unnecessary when the value of remaining
          // is smaller.
          buf = new byte[skip];
        }
        if ((skipped = in.read(buf, 0, skip)) == -1) {

     * 2) IP Address, NetBIOS name, nodeType, groupName - If however a
     * legal NetBIOS name string is used a name query request will retreive
     * the IP, node type, and whether or not this NbtAddress represents a
     * group name. This degree of state can be obtained with a Name Query
     * Request or Node Status Request.
     *
     * 3) All - The NbtAddress will be populated with all state such as mac

		// Removal of existing versions and adding a delete marker in the same
		// request is supported. At the same time, we cannot allow adding
		// two delete markers on top of any object. To avoid this situation,
		// we will sort deletions to execute existing deletion first,
		// then add only one delete marker if requested
		sort.SliceStable(fivs.Versions, func(i, j int) bool {
			return !fivs.Versions[i].Deleted
		})

	var (
		freeFi    FileInfo
		freeFound bool
	)
	found := false
	for _, ver := range x.versions {
		header := &ver.header
		// skip listing free-version unless explicitly requested via versionID
		if header.FreeVersion() {
			nonFreeVersions--
			// remember the latest free version; will return this FileInfo if no non-free version remain
			var freeVersion xlMetaV2Version

		policiesToUpdate = policiesToUpdate.Intersection(existingPolicySet)
		newPolicySet = existingPolicySet.Difference(policiesToUpdate)
	}
	// We return an error if the requested policy update will have no effect.
	if policiesToUpdate.IsEmpty() {
		err = errNoPolicyToAttachOrDetach
		return updatedAt, addedOrRemoved, effectivePolicies, err
	}

	newPolicies := newPolicySet.ToSlice()