"xds-port":            env.Register("ISTIOCTL_XDS_PORT", 15012, "The istioctl --xds-port override"),
	"authority":           env.Register("ISTIOCTL_AUTHORITY", "", "The istioctl --authority override"),
	"cert-dir":            env.Register("ISTIOCTL_CERT_DIR", "", "The istioctl --cert-dir override"),
	"insecure":            env.Register("ISTIOCTL_INSECURE", false, "The istioctl --insecure override"),

}

func validateDefaultOutput(t framework.TestContext, workload string) error { // nolint:interfacer
	t.Helper()
	istioCtl := istioctl.NewOrFail(t, t, istioctl.Config{})
	args := []string{"experimental", "metrics", workload}
	output, stderr, fErr := istioCtl.Invoke(args)
	if fErr != nil {
		t.Logf("Unwanted exception for 'istioctl %s': %v. Stderr: %v", strings.Join(args, " "), fErr, stderr)
		return fErr
	}

	// output will be something like

PHONYS := $(shell ls | grep -v Makefile)
.PHONY: $(PHONYS)
$(PHONYS):
	@$(MAKE_DOCKER) $@
endif

# istioctl-install builds then installs istioctl into $GOPATH/BIN
# Used for debugging istioctl during dev work
.PHONY: istioctl-install
istioctl-install: istioctl-install-container

ROOTDIR=$SCRIPTPATH/..
cd "$ROOTDIR" || exit

# rely on go build cache
ISTIOCTL=bin/istioctl
go build -o $ISTIOCTL ./istioctl/cmd/istioctl

for f in samples/**/*.yaml; do
  if grep -q -e "{{" "$f" ; then
    echo "Skipping check for helm template $f"
    continue
  else
    echo "Validating $f..."
  $ISTIOCTL validate -x \
    -f "$f"
  fi

kind: bug-fix
area: istioctl
issue:
  - https://github.com/istio/istio/issues/35539

releaseNotes:
- |

	"istio.io/istio/pkg/test/framework/components/istioctl"
)

func TestPostInstallControlPlaneVerification(t *testing.T) {
	framework.
		NewTest(t).
		Run(func(t framework.TestContext) {
			istioCtl := istioctl.NewOrFail(t, t, istioctl.Config{})
			cs := t.Environment().Clusters().Default()
			cleanupInClusterCRs(t, cs)
			t.Cleanup(func() {
				cleanupIstioResources(t, cs, istioCtl)
			})
			s := t.Settings()

apiVersion: release-notes/v2
kind: feature
area: installation
releaseNotes:
  - |
    **Removed** the `istioctl experimental revision` command. Revisions can be inspected by the stable `istioctl tag list` command.
  - |
    **Removed** the `installed-state` `IstioOperator` that was created when running `istioctl install`. This previously provided only a snapshot
    of what was installed.

import (
	"istio.io/istio/pkg/env"
	"istio.io/istio/pkg/log"
)

const (
	// Location to read istioctl defaults from
	defaultIstioctlConfig = "$HOME/.istioctl/config.yaml"
)

var (
	// IstioConfig is the name of the istioctl config file (if any)
	IstioConfig = env.Register("ISTIOCONFIG", defaultIstioctlConfig,
		"Default values for istioctl flags").Get()

	LoggingOptions = defaultLogOptions()

apiVersion: release-notes/v2
kind: feature
area: istioctl
issue:
  - 18487

releaseNotes:
- |

apiVersion: release-notes/v2
kind: feature
area: istioctl
releaseNotes:
- |
  **Updated** `istioctl x create-remote-secret` and `istioctl x remote-clusters` to the top level command, out of