revision: "",
			cfg: Config{
				Prefix:   "default",
				Revision: "istio.io/rev=XXX",
			},
			wantRevision: "istio.io/rev=XXX",
		},
		{
			name:     "NoOverwriteNonEmptyInput",
			revision: "BadRevision",
			cfg: Config{
				Prefix:   "default",
				Revision: "istio.io/rev=XXX",
			},
			wantRevision: "istio.io/rev=XXX",
		},
		{
			name:     "OverwriteNonEmptyInput",
			revision: "istio.io/rev=canary",

				Labels: map[string]string{"a": "b"},
			},
		},
	}

	ss := mkStatefulSet(&podTemplate)

	var (
		valid       = newControllerRevision("validname", "validns", &ss, 0)
		badRevision = newControllerRevision("validname", "validns", &ss, -1)
		emptyName   = newControllerRevision("", "validns", &ss, 0)
		invalidName = newControllerRevision("NoUppercaseOrSpecialCharsLike=Equals", "validns", &ss, 0)