if (!modelResult.getProblems().isEmpty()) {
                    List<ModelProblem> problems = modelResult.getProblems();
                    if (logger.isDebugEnabled()) {
                        String problem = (problems.size() == 1) ? "problem" : "problems";
                        String problemPredicate = problem + ((problems.size() == 1) ? " was" : " were");
                        String message = String.format(

            ModelBuildingRequest request,
            ModelProblemCollector problems) {
        model.update(
                injectProfile(model.getDelegate(), profile != null ? profile.getDelegate() : null, request, problems));
    }

    @Override
    public Model injectProfile(
            Model model, Profile profile, ModelBuildingRequest request, ModelProblemCollector problems) {

            java.io.File projectDir,
            ModelBuildingRequest request,
            ModelProblemCollector problems) {
        return new org.apache.maven.model.Model(interpolateModel(
                model.getDelegate(), projectDir != null ? projectDir.toPath() : null, request, problems));
    }

    @Override
    public org.apache.maven.model.Model interpolateModel(

    "functionalTests": true,
    "crossVersionTests": true
  },
  {
    "name": "problems",
    "path": "platforms/ide/problems",
    "unitTests": true,
    "functionalTests": true,
    "crossVersionTests": false
  },
  {
    "name": "problems-api",
    "path": "platforms/ide/problems-api",
    "unitTests": true,
    "functionalTests": true,
    "crossVersionTests": false
  },

        Model model = read(pom);

        SimpleProblemCollector problems = new SimpleProblemCollector(model);

        ModelBuildingRequest request = requestConfigurer.apply(new DefaultModelBuildingRequest());

        validator.validateFileModel(model, request, problems);

        validator.validateRawModel(model, request, problems);

        return problems;
    }

    private void assertContains(String msg, String substring) {

#### Internal API changes

The `okhttp3.internal` package is not a published API and we change it frequently without warning.
Depending on code in this package is bad and will cause you problems with any upgrade! But the 4.x
will be particularly painful to naughty developers that import from this package! We changed a lot
to take advantage of sweet Kotlin features.

#### Credentials.basic()

            LOGGER.warn("");
            LOGGER.warn("Some problems were encountered while building the effective settings");

            for (SettingsProblem problem : settingsResult.getProblems()) {
                LOGGER.warn("{} @ {}", problem.getMessage(), problem.getLocation());
            }
            LOGGER.warn("");
        }
    }

            context.logger.warn("");
            context.logger.warn("Some problems were encountered while building the effective toolchains");

            for (BuilderProblem problem : toolchainsResult.getProblems()) {
                context.logger.warn(problem.getMessage() + " @ " + problem.getLocation());
            }

            context.logger.warn("");
        }
    }

when defining configurable parts of a plugin (tasks, extensions, domain objects).  The Provider API provides a consistent way to set conventions, wire related configuration together (extension <- domain object <- task) and avoid evaluation ordering problems.

The Gradle codebase has evolved over time and has a mixture of simple getter/setter methods, Provider API and things in between.  It can be hard to follow best practices because Gradle provided types are reused in unexpected ways and extended...

        testing/architecture-test/build/reports/binary-compatibility/report.html => binary-compatibility-reports
        build/reports/dependency-verification/** => dependency-verification-reports
        build/reports/problems/problems-report.html
    """.trimIndent()

    paramsForBuildToolBuild(buildJvm, os, arch)
    params {
        // The promotion job doesn't have a branch, so %teamcity.build.branch% doesn't work.