"System.getProperties().get('some.property')",
                                     "getProperties().get('some.property')",
                                     "System.getProperty('some.property')",
                                     "System.getProperty(*['some.property'])",
                                     "getProperty('some.property')",

                property("kind", "SystemProperty")
                comma()
                property("name", trace.name)
            }

            is PropertyTrace.Task -> {
                property("kind", "Task")
                comma()
                property("path", trace.path)
                comma()
                property("type", trace.type.name)
            }

        "System.properties['some.property']"                   | _
        "System.getProperties().get('some.property')"          | _
        "getProperties().get('some.property')"                 | _
        "System.getProperty('some.property')"                  | _
        "getProperty('some.property')"                         | _
        "System.getProperty('some.property', 'default.value')" | _
        "getProperty('some.property', 'default.value')"        | _

        "System.getProperties().get(\"some.property\")"            | _
        "System.getProperty(\"some.property\")"                    | _
        "System.getProperty(\"some.property\", \"default.value\")" | _
        "System.setProperty(\"some.property\", \"new.value\")"     | _
        "System.clearProperty(\"some.property\")"                  | _
    }

    def "setProperties is instrumented in Java"() {

        configurationCacheRun("-Dfirst.property=first.value", "-Dsecond.property=second.value")

        then:
        outputContains("returned = first.value")
        outputContains("returned = second.value")
        result.assertHasPostBuildOutput("Configuration cache entry stored.")
        problems.assertResultHasProblems(result) {
            withInput("Plugin class 'FirstPlugin': system property 'first.property'")

        "System.getProperties().get(\"some.property\")"            | _
        "System.getProperty(\"some.property\")"                    | _
        "System.getProperty(\"some.property\", \"default.value\")" | _
        "System.setProperty(\"some.property\", \"new.value\")"     | _
        "System.clearProperty(\"some.property\")"                  | _
    }

        onAccess(MemberKind.PROPERTY, name)
        return delegate.hasProperty(name)
    }

    override fun tryGetProperty(name: String): DynamicInvokeResult {
        onAccess(MemberKind.PROPERTY, name)
        return delegate.tryGetProperty(name)
    }

    override fun trySetProperty(name: String, value: Any?): DynamicInvokeResult {
        onAccess(MemberKind.PROPERTY, name)

    def "from-cache build fails when task action closure reads a project property"() {
        given:
        buildFile << """
            tasks.register("some") {
                doFirst {
                    println(name) // task property is ok
                    println($expression)
                }
            }
        """

        when:

            import ${TaskAction.name};
            import ${Internal.name};
            import ${Property.name};

            public class CustomTask extends DefaultTask {
                private final Property<String> greeting = getProject().getObjects().property(String.class);

                @Internal
                public Property<String> getGreeting() {
                    return greeting;
                }

    }

    interface Dsl {
        val property: Property<String>
    }

    @Test
    fun `can serialize Java lambda with Gradle model`() {
        val stored = newInstance<Dsl>().apply {
            property.set("42")
        }
        val loaded = valueCarriedBy(roundtripOf(isolatedActionLambdaWith(stored)))
        assertThat(
            loaded.property.get(),
            equalTo("42")
        )
    }