# ADR-0002 - Avoid using Java serialization

## Status

- ACCEPTED on 2023-12-01

## Context

In Gradle we often need to serialize in-memory objects for caching, or to transmit them across process barriers, etc.
Java serialization is one way to implement this, however, despite its simplicity of implementation, it has several drawbacks:

- **Performance:**
Java's built-in serialization mechanism is often slower compared to other serialization solutions.

                }

                serverChallenge = msg2.getChallenge();
                ntlmsspFlags &= msg2.getFlags();

                //                  netbiosName = getNtlmsspListItem(token, 0x0001);

                final Type3Message msg3 =
                        new Type3Message(msg2, auth.getPassword(), auth.getDomain(), auth.getUsername(), workstation, ntlmsspFlags);
                token = msg3.toByteArray();

    assertWellFormed(
        0x61, 0xc8, 0x8a, 0x63, 0xc2, 0xa2, 0x62, 0x5c, 0x75, 0x30, 0x32, 0x34, 0x42, 0x36, 0x32,
        0x75, 0x30, 0x32, 0x30, 0x61, 0x63, 0x63, 0xc2, 0xa2, 0x64, 0x65, 0xc9, 0x8b, 0x36, 0x32);
    // Not a valid string
    assertNotWellFormed(-1, 0, -1, 0);
  }

  public void testShardsHaveExpectedRoundTrippables() {
    // A sanity check.
    long actual = 0;

        SMBUtil.writeInt2(getSubCommand() & 0xFF, dst, dstIndex);
        dstIndex += 2;
        System.arraycopy(descr, 0, dst, dstIndex, descr.length);
        dstIndex += descr.length;
        SMBUtil.writeInt2(0x0001, dst, dstIndex);
        dstIndex += 2;
        SMBUtil.writeInt2(this.maxDataCount, dst, dstIndex);
        dstIndex += 2;
        SMBUtil.writeInt4(this.serverTypes, dst, dstIndex);
        dstIndex += 4;

    static final byte TRANS2_FIND_NEXT2 = (byte) 0x02;
    static final byte TRANS2_QUERY_FS_INFORMATION = (byte) 0x03;
    static final byte TRANS2_QUERY_PATH_INFORMATION = (byte) 0x05;
    static final byte TRANS2_GET_DFS_REFERRAL = (byte) 0x10;
    static final byte TRANS2_SET_FILE_INFORMATION = (byte) 0x08;

    static final int NET_SHARE_ENUM = 0x0000;
    static final int NET_SERVER_ENUM2 = 0x0068;

        assertTrue(str.contains("name=test.txt"), "The file name should appear");
        // securityFlags are set to 0x03 – verify hex sequence
        assertTrue(str.contains("securityFlags=0x03"), "securityFlags should be present");
    }

    /**
     * Fetch a private field value via reflection.  This helper keeps the

            createDisposition = FILE_OPEN;
        }

        if ((createOptions & 0x0001) == 0) {
            this.createOptions = createOptions | 0x0040;
        } else {
            this.createOptions = createOptions;
        }
        impersonationLevel = 0x02; // As seen on NT :~)
        securityFlags = (byte) 0x03; // SECURITY_CONTEXT_TRACKING | SECURITY_EFFECTIVE_ONLY
    }

    @Override

        buffer.put((byte) 0x01); // SubAuthorityCount
        buffer.put(new byte[] { 0, 0, 0, 0, 0, 2 }); // IdentifierAuthority
        buffer.putInt(0); // SubAuthority

        // DACL at offset 60
        buffer.position(60);
        buffer.put((byte) 0x02); // AclRevision
        buffer.put((byte) 0x00); // Padding
        buffer.putShort((short) 8); // AclSize
        buffer.putShort((short) 0); // AceCount

        smb.pid = 456;
        smb.tid = 789;
        smb.uid = 101;
        smb.flags2 = ServerMessageBlock.FLAGS2_UNICODE;
        smb.useUnicode = true;

        byte[] params = { 0x01, 0x02, 0x03, 0x04 };
        byte[] bytes = { 0x0A, 0x0B, 0x0C, 0x0D, 0x0E, 0x0F };
        smb.setParamWords(params);
        smb.setBytes(bytes);

        byte[] buffer = new byte[1024];

        int bytesWritten = request.writeBytesWireFormat(buffer, offset);

        // Then
        assertEquals(4, bytesWritten);

        // Expected wire format: [0x04, 0x00, 0x00, 0x00]
        byte[] expected = new byte[] { 0x04, 0x00, 0x00, 0x00 };
        assertArrayEquals(expected, buffer);
    }

    @Test
    @DisplayName("Should always return 0 for readBytesWireFormat")
    void testReadBytesWireFormat() {