func IstiodHost(ns string, revision string) string {
	istiod := "istiod"
	if isRevisioned(revision) {
		istiod = fmt.Sprintf("%s-%s", istiod, revision)
	}
	return fmt.Sprintf("%s.%s.svc", istiod, ns)
}

func IstiodAddr(ns, revision string) string {
	// TODO make port configurable
	return fmt.Sprintf("%s:%d", IstiodHost(ns, revision), 15012)
}

// Returns a map with each k,v entry on a new line

)

type testCase struct {
	version        string
	revision       string
	expectedOutput diag.Messages
	expectedError  error
}

func Test_checkFromVersion(t *testing.T) {
	cases := []testCase{
		{
			revision:       "canary",
			version:        "1.21",
			expectedOutput: diag.Messages{},
			expectedError:  nil,
		},
		{
			revision:       "canary",
			version:        "XX",
			expectedOutput: nil,

}

func getMeshConfigFromConfigMap(ctx cli.Context, command, revision string) (*meshconfig.MeshConfig, error) {
	client, err := ctx.CLIClient()
	if err != nil {
		return nil, err
	}

	if meshConfigMapName == defaultMeshConfigMapName && revision != "" {
		meshConfigMapName = fmt.Sprintf("%s-%s", defaultMeshConfigMapName, revision)
	}

                }

                return sid.revision == this.revision;
            }
        }
        return false;
    }


    /**
     * Return the numeric representation of this sid such as
     * <tt>S-1-5-21-1496946806-2192648263-3843101252-1029</tt>.
     */
    @Override
    public String toString () {
        String ret = "S-" + ( this.revision & 0xFF ) + "-";

## Architecture Standards

**Experimental!**

We'd like to capture our architectural decisions about the build tool as [Architectural Decision Records (ADRs)](https://adr.github.io/).
For now we just have this global repository of ADRs.
If we see fit, we can break these out to per-platform ones, or keep a hybrid approach to having global and platform-specific ADSs.

Our aim is to keep the process lightweight and approachable.

}

type instance struct {
	// clients are cached clients for each revision
	clients map[string]kube.CLIClient
	// remoteClients are cached clients for each context with empty revision.
	remoteClients map[string]kube.CLIClient
	RootFlags
}

func newKubeClientWithRevision(kubeconfig, configContext, revision string, impersonateConfig rest.ImpersonationConfig) (kube.CLIClient, error) {

			args:          strings.Split("random-gibberish-podname-61789237418234", " "),
			wantException: true,
		},
		{ // case 6: new --revision argument
			args:           strings.Split("--revision canary", " "),
			expectedString: "NAME     CLUSTER     CDS     LDS     EDS     RDS     ECDS     ISTIOD",
			revision:       "canary",
		},
		{ // case 7: supplying type that doesn't select pods should fail

			return nil
		},
	}

	waypointApplyCmd.Flags().StringVarP(&revision, "revision", "r", "", "The revision to label the waypoint with")
	waypointApplyCmd.Flags().BoolVarP(&waitReady, "wait", "w", false, "Wait for the waypoint to be ready")
	waypointGenerateCmd.Flags().StringVarP(&revision, "revision", "r", "", "The revision to label the waypoint with")
	waypointCmd.AddCommand(waypointGenerateCmd)

                    "patch": 3
                },
                "metadata": {
                        "build.type": "RELEASE",
                        "revision.sha": "436f365a8007cd8a13a9f1321e7cce94bcc8883e",
                        "revision.status": "Clean",
                        "ssl.version": "BoringSSL"
                    }
            }
        }
    }

              "minorNumber": 18,
              "patch": 3
            },
            "metadata": {
              "build.type": "RELEASE",
              "revision.sha": "436f365a8007cd8a13a9f1321e7cce94bcc8883e",
              "revision.status": "Clean",
              "ssl.version": "BoringSSL"
            }
          }
        }
      }
    }
  ]