# MinIO Pull Request Guidelines

These guidelines ensure high-quality commits in MinIO’s GitHub repositories, maintaining 
a clear, valuable commit history for our open-source projects. They apply to all contributors, 
fostering efficient reviews and robust code.

## Why Pull Requests?

Pull Requests (PRs) drive quality in MinIO’s codebase by:
- Enabling peer review without pair programming.
- Documenting changes for future reference.

- Ingress objects are now persisted in etcd using the `networking.k8s.io/v1beta1` version (...

include("build-platform")

// Compute the identity/version we are building and related details (like current git commit)
include("module-identity")

// Code quality rules common to :build-logic and the root build
include("code-quality-rules")

// Plugins to build :build-logic plugins
include("gradle-plugin")

// Plugins to publish gradle projects
include("publishing")

* GCI: Remove /var/lib/docker/network ([#37593](https://github.com/kubernetes/kubernetes/pull/37593), [@yujuhong](https://github.com/yujuhong))
* Fix the equality checks for numeric values in cluster/gce/util.sh. ([#37638](https://github.com/kubernetes/kubernetes/pull/37638), [@roberthbailey](https://github.com/roberthbailey))

		return false
	}
	// check if policies match between sites
	var prev *lifecycle.Rule
	for i, r := range rules {
		if i == 0 {
			prev = r
			continue
		}
		// Check equality of rules
		prevRData, err := xml.Marshal(prev)
		if err != nil {
			return false
		}
		rData, err := xml.Marshal(*r)
		if err != nil {
			return false
		}

plugins {
    id("gradlebuild.build-logic.kotlin-dsl-gradle-plugin")
}

description = "Provides plugins to configure quality checks (incubating report, CodeNarc, et al)"

dependencies {
    implementation("gradlebuild:basics")

    implementation(projects.cleanup)
    implementation(projects.documentation)
    implementation(projects.integrationTesting)
    implementation(projects.jvm)
    implementation(projects.performanceTesting)

    config.convention(project.isolated.rootProject.projectDirectory.file("gradle/detekt.yml"))

    // also check the project build file
    source.from(project.buildFile)
}

pluginManager.withPlugin("gradlebuild.code-quality") {
    tasks {
        named("codeQuality") {
            dependsOn(detekt)
        }
    }

                        "type": "org.gradle.api.plugins.quality.Checkstyle",
                        "member": "Method org.gradle.api.plugins.quality.Checkstyle.getInstantiator()",
                        "changes": ["Method has been removed"],
                        "acceptation": "use ObjectFactory instead"
                    },
                    {
                        "type": "org.gradle.api.plugins.quality.CodeNarc",

        "parallelizationMethod": {
          "name": "TestDistribution"
        }
      },
      {
        "subprojects": [
          "build-cache-http",
          "build-events",
          "code-quality",
          "java-platform",
          "language-jvm",
          "plugins-distribution",
          "plugins-test-report-aggregation",
          "plugins-version-catalog",
          "resources-sftp",

import org.gradle.api.file.Directory;
import org.gradle.api.file.DirectoryProperty;
import org.gradle.api.file.FileSystemOperations;
import org.gradle.api.file.ProjectLayout;
import org.gradle.api.plugins.quality.Checkstyle;
import org.gradle.api.plugins.quality.CheckstyleExtension;
import org.gradle.api.specs.Spec;
import org.gradle.api.tasks.Copy;
import org.gradle.api.tasks.PathSensitivity;
import org.gradle.api.tasks.TaskContainer;