revision:  rev,
					namespace: ns,
				})
			}

			// create an echo instance in each revisioned namespace, all these echo
			// instances will be injected with proxies from their respective versions
			builder := deployment.New(t)

			for _, ns := range revisionedNamespaces {
				builder = builder.WithConfig(echo.Config{
					Service:   fmt.Sprintf("revision-%s", ns.revision),
					Namespace: ns.namespace,

apiVersion: release-notes/v2
kind: feature
area: istioctl
releaseNotes:
  - |
    **Added** `revision` flag to admin log to switch controls between Istiods.
  - |

			for _, rev := range extraRevs {
				namespaces = append(namespaces, revisionedNamespace{
					revision: rev,
					namespace: namespace.NewOrFail(t, t, namespace.Config{
						Prefix:   fmt.Sprintf("revision-%s", rev),
						Inject:   true,
						Revision: rev,
					}),
				})
			}
			// Allow all namespaces so we do not hit passthrough cluster

  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
  <modelVersion>4.0.0</modelVersion>
  <groupId>com.example.group</groupId>
  <artifactId>valid-version-revision</artifactId>
  <version>${revision}</version>

  <description>
    This will test if the validation for the ci friendly versions
    is working correct.
  </description>

apiVersion: release-notes/v2
kind: promotion
area: istioctl
releaseNotes:
  - |

kind: bug-fix
area: installation

# issue is a list of GitHub issues resolved in this note.
issue:
  - 47552

releaseNotes:
- |

apiVersion: release-notes/v2
kind: feature
area: installation
releaseNotes:
  - |
    **Updated** non-revisioned installs to target the label `istio.io/rev=default` for injection in addition to the

				NoCleanup:         true,
			},
			expectErr: true,
		},
		{
			name: "fail on both revision and revisions flag",
			settings: &Settings{
				Revision:      "a",
				Compatibility: false,
				Revisions: RevVerMap{
					"b": "",
				},
			},
			expectErr: true,
		},
		{
			name: "fail when compatibility mode but no revisions",
			settings: &Settings{
				Compatibility: true,
			},
			expectErr: true,
		},

apiVersion: release-notes/v2
kind: bug-fix
area: installation
releaseNotes:
  - |
    **Fixed** a bug resulting in broken resource validation when a fresh Istio installation specified a revision. Note that
    this fix applies only when using the `istioctl` installation method, the manual steps from the [canary upgrade documentation](https://istio.io/latest/docs/setup/upgrade/canary/)

// elections, with one difference: the "default" revision will steal the lock from other revisions.
func NewLeaderElection(namespace, name, electionID, revision string, client kube.Client) *LeaderElection {
	return newLeaderElection(namespace, name, electionID, revision, false, false, client)
}

// NewPerRevisionLeaderElection creates a *per revision* leader election. This means there will be one leader for each revision.