# ADR-0002 - Avoid using Java serialization

## Status

- ACCEPTED on 2023-12-01

## Context

In Gradle we often need to serialize in-memory objects for caching, or to transmit them across process barriers, etc.
Java serialization is one way to implement this, however, despite its simplicity of implementation, it has several drawbacks:

- **Performance:**
Java's built-in serialization mechanism is often slower compared to other serialization solutions.

                }

                serverChallenge = msg2.getChallenge();
                ntlmsspFlags &= msg2.getFlags();

                //                  netbiosName = getNtlmsspListItem(token, 0x0001);

                final Type3Message msg3 =
                        new Type3Message(msg2, auth.getPassword(), auth.getDomain(), auth.getUsername(), workstation, ntlmsspFlags);
                token = msg3.toByteArray();

            dstIndex++;
            dst[dstIndex++] = (byte) 0x00; // Reserved1
            writeInt2(flags, dst, dstIndex);
            dstIndex += 2;
            writeInt4(timeout, dst, dstIndex);
            dstIndex += 4;
            dst[dstIndex++] = (byte) 0x00; // Reserved2
            dst[dstIndex++] = (byte) 0x00;
        }
        writeInt2(parameterCount, dst, dstIndex);
        dstIndex += 2;

    @ParameterizedTest
    @CsvSource({ "4, 257", // FILE_BASIC_INFO -> 0x0101
            "5, 258", // FILE_STANDARD_INFO -> 0x0102
            "20, 260" // FILE_ENDOFFILE_INFO -> 0x0104
    })
    void testWithDifferentInformationLevels(byte infoLevel, int expectedMappedValue) {
        when(mockFileInfo.getFileInformationLevel()).thenReturn(infoLevel);

        assertNotNull(signingKey, "Should handle large session key");
        assertEquals(16, signingKey.length, "Should still produce 16-byte key");
    }

    @ParameterizedTest
    @ValueSource(ints = { 0x0300, 0x0302, 0x0310 }) // Non-3.1.1 dialects
    @DisplayName("Should use SMB 3.0.x context for non-3.1.1 dialects")
    void testDeriveKeys_NonSMB311Dialects(int dialect) {
        // When

        buffer.put((byte) 0x01); // SubAuthorityCount
        buffer.put(new byte[] { 0, 0, 0, 0, 0, 2 }); // IdentifierAuthority
        buffer.putInt(0); // SubAuthority

        // DACL at offset 60
        buffer.position(60);
        buffer.put((byte) 0x02); // AclRevision
        buffer.put((byte) 0x00); // Padding
        buffer.putShort((short) 8); // AclSize
        buffer.putShort((short) 0); // AceCount

     */
    public static final int DFS_VOLUME_FLAVOR_AD_BLOB = 0x200;
    /**
     * DFS storage state indicating offline status
     */
    public static final int DFS_STORAGE_STATE_OFFLINE = 0x0001;
    /**
     * DFS storage state indicating online status
     */
    public static final int DFS_STORAGE_STATE_ONLINE = 0x0002;
    /**
     * DFS storage state indicating active status
     */

    }

    @Test
    void testWriteHeaderReadHeader() {
        byte[] buffer = new byte[32];
        smb.command = ServerMessageBlock.SMB_COM_NEGOTIATE;
        smb.flags = (byte) 0x18;
        smb.flags2 = 0x0001;
        smb.tid = 1;
        smb.pid = 2;
        smb.uid = 3;
        smb.mid = 4;

        smb.writeHeaderWireFormat(buffer, 0);

        TestServerMessageBlock readSmb = new TestServerMessageBlock();

        byte[] data1 = { 0x00, 0x01, 0x02, 0x03 };
        assertEquals("00", Hexdump.toHexString(data1, 0, 2)); // 2 chars = 1 byte
        assertEquals("000", Hexdump.toHexString(data1, 0, 3)); // 3 chars = 1.5 bytes (rounds up to 2)
        assertEquals("0001", Hexdump.toHexString(data1, 0, 4)); // 4 chars = 2 bytes
        assertEquals("000102", Hexdump.toHexString(data1, 0, 6)); // 6 chars = 3 bytes

        int bytesWritten = request.writeBytesWireFormat(buffer, offset);

        // Then
        assertEquals(4, bytesWritten);

        // Expected wire format: [0x04, 0x00, 0x00, 0x00]
        byte[] expected = new byte[] { 0x04, 0x00, 0x00, 0x00 };
        assertArrayEquals(expected, buffer);
    }

    @Test
    @DisplayName("Should always return 0 for readBytesWireFormat")
    void testReadBytesWireFormat() {