3. Add tests
4. Handle resources properly (try-with-resources)
5. Consider thread safety
6. Update JavaDoc

### When Fixing Bugs

1. Write failing test first
2. Understand root cause
3. Minimal changes
4. Verify no regressions

### When Refactoring

1. Preserve behavior
2. Keep tests green
3. Small incremental steps
4. Don't mix with new features

### Code Quality Checklist

        assertEquals(0, bytesRead);
    }

    @Test
    @DisplayName("Test size calculation with different buffer sizes")
    void testSizeCalculationWithDifferentBufferSizes() {
        // Test with smaller maximum buffer size
        when(mockConfig.getMaximumBufferSize()).thenReturn(8192);
        when(mockConfig.getListSize()).thenReturn(16384);

        request = new Smb2QueryDirectoryRequest(mockConfig);

        assertThrows(SMBProtocolDecodingException.class, () -> {
            notifyInfo.decode(buffer, 0, buffer.length);
        });
    }

    @Test
    @DisplayName("Test decode with maximum file name length")
    void testDecodeMaxFileNameLength() throws SMBProtocolDecodingException {
        // Create a very long filename (but within reasonable bounds)
        StringBuilder sb = new StringBuilder();

        // When
        request.setTid(tid);

        // Then
        verify(request, times(1)).setTid(tid);
    }

    @Test
    @DisplayName("Test setTid with maximum integer value")
    void testSetTidWithMaxValue() {
        // Given
        int tid = Integer.MAX_VALUE;
        doNothing().when(request).setTid(tid);

        // When
        request.setTid(tid);

    @Test
    void readWireFormat_shouldDelegateToParent() {
        // Arrange
        nodeStatusRequest = new NodeStatusRequest(mockConfig, mockName);
        byte[] src = new byte[200];
        // Setup minimal valid header
        src[0] = 0x00;
        src[1] = 0x01; // Transaction ID
        src[2] = 0x00; // Flags
        src[3] = 0x00; // Flags
        src[4] = 0x00;
        src[5] = 0x01; // Question count

    @Mock
    private sid_t mockSidT;

    private MsrpcLookupSids lookupSids;
    private jcifs.SID[] testSids;

    @BeforeEach
    void setUp() {
        // Setup is minimal - mocks are configured per test as needed
    }

    @Test
    void constructor_shouldInitializeWithValidParameters() {
        // Arrange
        jcifs.SID mockSid1 = mock(jcifs.SID.class);

            request.writeBytesWireFormat(smallBuffer, 0);
        });
    }

    @Test
    @DisplayName("Test file ID boundary values")
    void testFileIdBoundaryValues() {
        // Test with file ID having maximum byte values
        byte[] maxFileId = new byte[16];
        Arrays.fill(maxFileId, (byte) 0xFF);
        Smb2FlushRequest maxRequest = new Smb2FlushRequest(mockConfig, maxFileId);

        byte[] buffer = new byte[256];

import jcifs.internal.smb2.Smb2Constants;
import jcifs.internal.util.SMBUtil;
import jcifs.smb.NtStatus;
import jcifs.smb.SmbException;

class Smb2IoctlResponseTest {

    // Helper: build a minimal SMB2 header with a given status
    private static byte[] buildHeader(int status) {
        byte[] hdr = new byte[64]; // SMB2 header is 64 bytes
        System.arraycopy(SMBUtil.SMB2_HEADER, 0, hdr, 0, 64);

        // The decode method returns only the header size (16 bytes)
        assertEquals(16, bytesDecoded);
    }

    @Test
    @DisplayName("Test decode with maximum values")
    void testDecodeWithMaxValues() throws SMBProtocolDecodingException {
        // Prepare test data with max values
        byte[] buffer = new byte[20]; // 16 header + 4 data
        int bufferIndex = 0;

        assertEquals("https://second.com", data.getUrl());
        assertEquals(2.0f, data.getWeight(), 0.001f);
    }

    public void test_minimalUsage() {
        // Test minimal usage (just URL)
        RequestData data = RequestDataBuilder.newRequestData().url("https://example.com").build();

        assertNull(data.getMethod());
        assertEquals("https://example.com", data.getUrl());