# ADR-0008 - Use NullAway for null checking

## Status

- ACCEPTED on 2025-08-06

## Context

Our codebase uses `null` extensively to represent an absence of value or optionality of the argument.
We utilize nullness annotations in Java code and somewhat rely on IDE warnings to guide us.
However, the Java code we have is not fully annotated, which causes several consequences:
* IDE warnings can be misleading

     */
    @Override
    protected OptionalThing<LoginManager> myLoginManager() {
        return OptionalThing.empty();
    }

    /**
     * Pre-processes API requests by checking access authorization before executing the action.
     * If access is not allowed, returns an unauthorized error response.
     *
     * @param runtime the action runtime context containing request information

    IF "%%A"=="wrapperUrl" SET DOWNLOAD_URL=%%B
)

@REM Extension to allow automatically downloading the maven-wrapper.jar from Maven-central
@REM This allows using the maven wrapper in projects that prohibit checking in binary data.
if exist %WRAPPER_JAR% (
    if "%MVNW_VERBOSE%" == "true" (
        echo Found %WRAPPER_JAR%
    )
) else (
    if not "%MVNW_REPOURL%" == "" (

        // Execute
        final SsoMessageException exception = new SsoMessageException(messageCode, message);

        // Verify that it has serialVersionUID (indirectly by checking it's serializable)
        assertTrue(exception instanceof java.io.Serializable);
    }

import com.fasterxml.jackson.databind.ObjectMapper;

import jakarta.servlet.http.HttpSession;

/**
 * Abstract base class for LLM client implementations.
 *
 * Provides shared infrastructure (HTTP client, availability checking) and
 * default implementations of RAG workflow methods with injectable prompt templates.
 * Subclasses implement provider-specific chat/streamChat and checkAvailabilityNow.
 */

    }

    /**
     * Test HTTP status code constants are defined correctly
     */
    @Test
    public void test_httpStatusCodeConstants() {
        // Verify the constants are accessible via reflection or by checking their usage
        // Since the constants are private, we test their values indirectly

        // The constants should match standard HTTP status codes
        // HTTP_STATUS_NOT_FOUND = 404
        // HTTP_STATUS_OK = 200

        }

        private
        inline fun <reified T> inAnyOrder(items: List<T>): Matcher<Iterable<T>> = inAnyOrder(items.toTypedArray())

        /**
         * Matcher checking each item is present exactly once in a given iterable, but an any position,
         * and that there are no unexpected items.
         */
        private

import jakarta.annotation.Resource;

/**
 * The assist for login handling in the Fess application.
 * This class extends TypicalLoginAssist to provide Fess-specific login functionality
 * including user authentication, permission checking, and login history management.
 *
 */
public class FessLoginAssist extends TypicalLoginAssist<String, FessUserBean, FessUser> // #change_it also UserBean
        implements PrimaryLoginManager {

    /**

            $olEle.css({
              "list-style": "none",
              padding: "0",
              margin: "2px"
            });

            // Use a Set to track seen texts for O(n) duplicate checking
            seenTexts = {};

            for (
              j = 0;
              j < reslist.length && listNum < settingAjaxInfo.num;
              j++
            ) {
              str = reslist[j];

    }

    /**
     * Test that convertWithFieldCheck() pattern reduces code duplication.
     * This test demonstrates how the template method can be used to replace
     * repetitive field checking logic.
     */
    @Test
    public void test_convertWithFieldCheck_reducesCodeDuplication() {
        FessConfig fessConfig = ComponentUtil.getFessConfig();