)

func Test_skipReplicaCountWithAutoscaleEnabled(t *testing.T) {
	const valuesWithHPAndReplicaCountFormat = `
values:
  pilot:
    autoscaleEnabled: %t
  gateways:
    istio-ingressgateway:
      autoscaleEnabled: %t
    istio-egressgateway:
      autoscaleEnabled: %t
components:
  pilot:
    k8s:
      replicaCount: 2
  ingressGateways:
    - name: istio-ingressgateway
      enabled: true
      k8s:

  namespace: {{ .Values.global.istioNamespace }}
  labels:
    app: istiod
    release: {{ .Release.Name }}
  {{- if .Values.pilot.serviceAccountAnnotations }}
  annotations:
{{- toYaml .Values.pilot.serviceAccountAnnotations | indent 4 }}
  {{- end }}

apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
spec:
  profile: empty
  hub: docker.io/istio
  tag: 1.1.4
  meshConfig:
    rootNamespace: istio-control
  components:
    pilot:
      enabled: true
      namespace: istio-control
  values:
    pilot:
      resources:
        requests:
          cpu: 222m
          memory: 333Mi
      autoscaleMax: 8
      autoscaleMin: 2
      rollingMaxUnavailable: 30%

kind: feature
area: installation

issue:
  - https://github.com/istio/istio/issues/40427

docs:
 - '[reference] https://istio.io/latest/docs/reference/commands/pilot-discovery/'

releaseNotes:
- |
  **Added** an `ENABLE_LEADER_ELECTION=false` feature flag for pilot-discovery

	k8s "sigs.k8s.io/gateway-api/apis/v1"

	networking "istio.io/api/networking/v1alpha3"
	"istio.io/istio/pilot/pkg/config/memory"
	"istio.io/istio/pilot/pkg/features"
	"istio.io/istio/pilot/pkg/model"
	"istio.io/istio/pilot/pkg/networking/core"
	"istio.io/istio/pilot/pkg/serviceregistry/kube/controller"
	"istio.io/istio/pilot/pkg/serviceregistry/util/xdsfake"
	"istio.io/istio/pkg/config"
	"istio.io/istio/pkg/config/constants"

// See the License for the specific language governing permissions and
// limitations under the License.

package options

import (
	meshconfig "istio.io/api/mesh/v1alpha1"
	"istio.io/istio/pilot/cmd/pilot-agent/status"
	"istio.io/istio/pilot/cmd/pilot-agent/status/ready"
	istioagent "istio.io/istio/pkg/istio-agent"
	"istio.io/istio/pkg/model"
)

dockerx.pushx: docker.push
	@:
dockerx: docker
	@:

# Support individual images like `dockerx.pilot`

# Docker commands defines some convenience targets
# Build individual docker image and push it. Ex: push.docker.pilot
push.docker.%:
	DOCKER_TARGETS=docker.$* ./tools/docker --push

# Build individual docker image and save it. Ex: tar.docker.pilot
tar.docker.%:
	DOCKER_TARGETS=docker.$* ./tools/docker --save

  namespace: {{ .Values.global.istioNamespace }}
  labels:
    app: istiod
    release: {{ .Release.Name }}
  {{- if .Values.pilot.serviceAccountAnnotations }}
  annotations:
{{- toYaml .Values.pilot.serviceAccountAnnotations | indent 4 }}
  {{- end }}
---

spec:
  profile: empty
  hub: docker.io/istio
  tag: 1.1.4
  meshConfig:
    rootNamespace: istio-control
  components:
    pilot:
      enabled: true
      namespace: istio-control
      k8s:
        hpaSpec:
          maxReplicas: 333
          scaleTargetRef:
            name: istio-pilot
          metrics:
          - type: Resource
            resource:
              name: cpu

apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
metadata:
  namespace: istio-system
spec:
  hub: gcr.io/istio-testing
  tag: latest

  # Turn on default components: base, pilot, and ingress gateway
  components:
    base:
      enabled: true
    pilot:
      enabled: true
    # Istio Gateway feature
    ingressGateways:
    - name: istio-ingressgateway
      enabled: true
    egressGateways: