apiVersion: apps/v1
kind: Deployment
metadata:
  name: traffic
spec:
  replicas: 7
  selector:
    matchLabels:
      app: traffic
  template:
    metadata:
      annotations:
        traffic.sidecar.istio.io/includeInboundPorts: "bad"
      labels:
        app: traffic
    spec:
      containers:
        - name: traffic
          image: "fake.docker.io/google-samples/traffic-go-gke:1.0"
          ports:
            - name: http

		t.Fatalf("expected nsenterFunc to be called")
	}
	r := mockIntercept.lastRedirect[len(mockIntercept.lastRedirect)-1]
	if r.includeInboundPorts != "*" {
		t.Fatalf("expect includeInboundPorts has value '*' set by istio, actual %v", r.includeInboundPorts)
	}
}

func TestCmdAddTwoContainersWithStarInboundPort(t *testing.T) {
	pod, ns := buildFakePodAndNSForClient()

	redir.excludeInboundPorts = strings.TrimSpace(redir.excludeInboundPorts)
	if len(redir.excludeInboundPorts) > 0 && redir.excludeInboundPorts[len(redir.excludeInboundPorts)-1] != ',' {
		redir.excludeInboundPorts += ","
	}
	redir.excludeInboundPorts += "15020,15021,15090"
	redir.excludeInboundPorts = strings.Join(dedupPorts(splitPorts(redir.excludeInboundPorts)), ",")

metadata:
  name: traffic
spec:
  replicas: 7
  selector:
    matchLabels:
      app: traffic
  template:
    metadata:
      annotations:
        traffic.sidecar.istio.io/includeInboundPorts: ""
        traffic.sidecar.istio.io/excludeInboundPorts: "4,5,6"
        traffic.sidecar.istio.io/includeOutboundIPRanges: ""
        traffic.sidecar.istio.io/excludeOutboundIPRanges: "10.96.0.2/24,10.96.0.3/24"
      labels:
        app: traffic

      "componentLogLevel": "misc:error",
      "enableCoreDump": false,
      "excludeIPRanges": "",
      "excludeInboundPorts": "",
      "excludeOutboundPorts": "",
      "holdApplicationUntilProxyStarts": true,
      "image": "proxyv2",
      "includeIPRanges": "*",
      "includeInboundPorts": "*",
      "includeOutboundPorts": "",
      "logLevel": "warning",
      "outlierLogPath": "",
      "privileged": false,

      "clusterDomain": "cluster.local",
      "componentLogLevel": "misc:error",
      "enableCoreDump": false,
      "excludeIPRanges": "",
      "excludeInboundPorts": "",
      "excludeOutboundPorts": "",
      "image": "proxyTest",
      "includeIPRanges": "*",
      "includeInboundPorts": "*",
      "includeOutboundPorts": "",
      "logLevel": "warning",
      "outlierLogPath": "",
      "privileged": false,

      "clusterDomain": "cluster.local",
      "componentLogLevel": "misc:error",
      "enableCoreDump": false,
      "excludeIPRanges": "",
      "excludeInboundPorts": "",
      "excludeOutboundPorts": "",
      "image": "proxyv2",
      "includeIPRanges": "*",
      "includeInboundPorts": "*",
      "includeOutboundPorts": "",
      "logLevel": "warning",
      "outlierLogPath": "",
      "privileged": false,

metadata:
  name: traffic
spec:
  replicas: 7
  selector:
    matchLabels:
      app: traffic
  template:
    metadata:
      annotations:
        traffic.sidecar.istio.io/includeInboundPorts: "*"
        traffic.sidecar.istio.io/excludeInboundPorts: "4,5,6"
        traffic.sidecar.istio.io/includeOutboundIPRanges: "*"
        traffic.sidecar.istio.io/excludeOutboundIPRanges: "10.96.0.2/24,10.96.0.3/24"
      labels:
        app: traffic

      annotations:
        # We set 4 CPUs here and concurrency=0 below. Expect concurrency to be set to 4.
        sidecar.istio.io/proxyCPU: 4000m
        traffic.sidecar.istio.io/includeInboundPorts: "1,2,3"
        traffic.sidecar.istio.io/excludeInboundPorts: "4,5,6"
        traffic.sidecar.istio.io/excludeOutboundPorts: "7,8,9"
        traffic.sidecar.istio.io/includeOutboundIPRanges: "127.0.0.1/24,10.96.0.1/24"

apiVersion: release-notes/v2
kind: bug-fix
area: installation
issue:
  - https://github.com/istio/istio/issues/36644
releaseNotes:
  - |