# ADR-0002 - Avoid using Java serialization

## Status

- ACCEPTED on 2023-12-01

## Context

In Gradle we often need to serialize in-memory objects for caching, or to transmit them across process barriers, etc.
Java serialization is one way to implement this, however, despite its simplicity of implementation, it has several drawbacks:

- **Performance:**
Java's built-in serialization mechanism is often slower compared to other serialization solutions.

# ADR-0003 - Avoid introducing Groovy types to public API

## Status

- ACCEPTED on 2024-01-12

## Context

Gradle's public API requires equal access from all JVM-based languages.
Kotlin, Groovy, Java, and other JVM-based languages should be able to use the Gradle API without relying on another language's standard library.

Historically, Gradle has shipped with some Groovy types in very prominent APIs.

    // Test implementation of ThumbnailManager to avoid container dependencies
    private class TestThumbnailManager extends ThumbnailManager {
        @Override
        public void init() {
            // Do nothing to avoid container access
        }

        @Override
        protected void storeQueue(List<Tuple3<String, String, String>> taskList) {
            // Override to avoid database operations
            taskList.clear();

Only keep parentheses if they exist in the source text. Do not add parentheses to terms that do not have them.

### Avoiding Repetition in Translation

When translating sentences, avoid unnecessary repetition of words or phrases that are implied in context.

For gradual adoption, enable checks project-by-project.
Do not rely on `@NullMarked` annotations.
Only enable checks for a project if all its dependencies have checks enabled, in order to avoid back-and-forth when refining the annotations.

Avoid writing the so-called `PolyNull` or `ParametricNull` methods (where nullability of the result depends on the nullability of the type argument).

@defaultMessage Avoid unchecked warnings by using Collections#empty(List|Map|Set) methods
java.util.Collections#EMPTY_LIST
java.util.Collections#EMPTY_MAP
java.util.Collections#EMPTY_SET

java.util.Collections#shuffle(java.util.List) @ Use java.util.Collections#shuffle(java.util.List, java.util.Random) with a reproducible source of randomness

  <parent>
    <groupId>com.google.guava</groupId>
    <artifactId>guava-parent</artifactId>
    <version>26.0-android</version>
  </parent>
  <artifactId>listenablefuture</artifactId>
  <version>9999.0-empty-to-avoid-conflict-with-guava</version>
  <name>Guava ListenableFuture only</name>
  <description>
    An empty artifact that Guava depends on to signal that it is providing

    protected void assertFalse(boolean condition, String message) {
        Assertions.assertFalse(condition, message);
    }

    // assertNull - JUnit 5 style only (to avoid ambiguity with String actual)
    protected void assertNull(Object actual, String message) {
        Assertions.assertNull(actual, message);
    }

    // assertNotNull - JUnit 5 style only (to avoid ambiguity with String actual)

      - name: GitHub CODEOWNERS Validator
        uses: mszostok/codeowners-validator@v0.7.4
        with:
          checks: "files,duppatterns,syntax"
          experimental_checks: "notowned,avoid-shadowing"

      # downgrading to 0.7.2 for owners check to avoid issues with token permissions check,
      # see https://github.com/mszostok/codeowners-validator/issues/224
      - name: GitHub CODEOWNERS Validator

        ObjectIdentifiers.SHA256_WITH_ECDSA -> "SHA256withECDSA"
        else -> error("unexpected signature algorithm: ${signature.algorithm}")
      }
    }

  // Avoid Long.hashCode(long) which isn't available on Android 5.
  override fun hashCode(): Int {
    var result = 0
    result = 31 * result + version.toInt()
    result = 31 * result + serialNumber.hashCode()