- address: 1.1.1.1
      labels:
        security.istio.io/tlsMode: istio
{{- range $i := until .Services }}
---
apiVersion: v1
kind: Service
metadata:
  name: service-{{$i}}
spec:
  type: ExternalName
  externalName: random-{{$i}}.example.com
  ports:
    - port: 80
      name: http

kind: bug-fix
area: traffic-management
issues:
  - 37331
releaseNotes:
  - |
    **Improved** support for `ExternalName` services. See Upgrade Notes for more information
upgradeNotes:
  - title: "Upcoming `ExternalName` support changes"
    content: |
      Below describes *upcoming* changes to `ExternalName`.
      In this release, there is no behavioral changes by default.

apiVersion: release-notes/v2
kind: bug-fix
area: traffic-management
issues:
  - 37331
releaseNotes:
  - |
    **Improved** support for `ExternalName` services. See Upgrade Notes for more information.
upgradeNotes:
  - title: "`ExternalName` support changes"
    content: |
      Kubernetes `ExternalName` `Service`s allow users to create new DNS entries. For example, you can create an `example` service

	addrs := []string{constants.UnspecifiedIP}
	resolution := model.ClientSideLB
	externalName := ""
	nodeLocal := false

	if svc.Spec.Type == corev1.ServiceTypeExternalName && svc.Spec.ExternalName != "" {
		externalName = svc.Spec.ExternalName
		if features.EnableExternalNameAlias {
			resolution = model.Alias
		} else {
			resolution = model.DNSLB
		}
	}

    targetPort: 15017
    name: tcp-webhook
    protocol: TCP
  {{- if not (regexMatch "^([0-9]*\\.){3}[0-9]*$" .Values.global.remotePilotAddress) }}
  # if the remotePilotAddress is not an IP addr, we use ExternalName
  type: ExternalName
  externalName: {{ .Values.global.remotePilotAddress }}
  {{- end }}
{{- if .Values.global.ipFamilyPolicy }}
  ipFamilyPolicy: {{ .Values.global.ipFamilyPolicy }}
{{- end }}
{{- if .Values.global.ipFamilies }}

    targetPort: 15017
    name: tcp-webhook
    protocol: TCP
  {{- if not (regexMatch "^([0-9]*\\.){3}[0-9]*$" .Values.global.remotePilotAddress) }}
  # if the remotePilotAddress is not an IP addr, we use ExternalName
  type: ExternalName
  externalName: {{ .Values.global.remotePilotAddress }}
  {{- end }}
{{- if .Values.global.ipFamilyPolicy }}
  ipFamilyPolicy: {{ .Values.global.ipFamilyPolicy }}
{{- end }}
{{- if .Values.global.ipFamilies }}

	svc.Spec.ExternalName = ""
	internalTrafficPolicy := api.ServiceInternalTrafficPolicyCluster
	svc.Spec.InternalTrafficPolicy = &internalTrafficPolicy
}

// SetTypeExternalName sets the service type to ExternalName and clears other fields.
func SetTypeExternalName(svc *api.Service) {
	svc.Spec.Type = api.ServiceTypeExternalName
	svc.Spec.ExternalName = "example.com"
	svc.Spec.ExternalTrafficPolicy = ""

		if instance.IsUnsupported() || port.Name == "tcp" && svc.Type == "ExternalName" {

			m := msg.NewPortNameIsNotUnderNamingConvention(
				r, port.Name, int(port.Port), port.TargetPort.String())

			if svc.Type == "ExternalName" {
				m = msg.NewExternalNameServiceTypeInvalidPortName(r)
			}

			if line, ok := util.ErrorLine(r, fmt.Sprintf(util.PortInPorts, i)); ok {

	}

	if service.Attributes.Type != string(extSvc.Spec.Type) ||
		service.Attributes.ExternalName != extSvc.Spec.ExternalName {
		t.Fatalf("service attributes incorrect => %v/%v, want %v/%v",
			service.Attributes.Type, service.Attributes.ExternalName, extSvc.Spec.Type, extSvc.Spec.ExternalName)
	}
}

func TestExternalClusterLocalServiceConversion(t *testing.T) {
	serviceName := "service1"

apiVersion: release-notes/v2
kind: bug-fix
area: traffic-management
issue:
  - https://github.com/istio/istio/issues/43440

releaseNotes:
  - |