- Is small, focused, and easy to review—ideally one commit, unless multiple commits better narrate complex work.
- Adheres to MinIO’s coding standards (e.g., Go style, error handling, testing).

PRs must flow smoothly through review to reach production. Large PRs should be split into smaller, manageable ones.

## Submitting PRs

It is quite an extensive specification and covers several complex use cases.

It includes ways to authenticate using a "third party".

That's what all the systems with "login with Facebook, Google, X (Twitter), GitHub" use underneath.

### OAuth 1 { #oauth-1 }

There was an OAuth 1, which is very different from OAuth2, and more complex, as it included direct specifications on how to encrypt the communication.

Disallow: /*.pdf$
Disallow: /admin/*.php
Disallow: /*/private/
Allow: /public/*.html

# Test end-of-path ($) patterns
User-agent: EndPathBot
Disallow: /fish$
Disallow: /temp$
Allow: /fishing

# Test complex patterns
User-agent: ComplexBot
Disallow: /
Allow: /$
Allow: /index.html$
Allow: /public/

# Test priority rules (longer match wins)
User-agent: PriorityBot
Disallow: /store
Allow: /store/public

    /**
     * This test primarily exists to ensure the constants interface can be loaded
     * and to provide a basic check of its values.
     * Since it's an interface with only static final fields, there is no complex logic to test.
     */
    @Test
    void testConstants() {
        // A simple assertion to verify that some of the constants have the expected values.

5. The daemon sends the result back. For some requests, this might be a simple success/failure result, and for others this might also include a more complex object, such as a tooling API model.

        // The fact that the object is successfully created implies the super constructor was called.
    }

    // Additional tests could be added here if MsrpcSamrOpenAlias had more methods or complex logic.
    // For this specific class, the constructor is the main point of logic.

# Extra Data Types { #extra-data-types }

Up to now, you have been using common data types, like:

* `int`
* `float`
* `str`
* `bool`

But you can also use more complex data types.

And you will still have the same features as seen up to now:

* Great editor support.
* Data conversion from incoming requests.
* Data conversion for response data.
* Data validation.
* Automatic annotation and documentation.

        assertTrue(auth.matches("ftp://192.168.1.1/test/aaa.html"));
        assertFalse(auth.matches("ftp://hostname/test/aaa.html"));

        // Test with more complex paths
        auth.setServer("hostname");
        auth.setPort(21);
        assertTrue(auth.matches("ftp://hostname:21/path/to/resource.txt"));
        assertTrue(auth.matches("ftp://hostname/path/to/resource.txt"));

* Validate **complex structures**:
    * Use of hierarchical Pydantic models, Python `typing`’s `List` and `Dict`, etc.
    * And validators allow complex data schemas to be clearly and easily defined, checked and documented as JSON Schema.

        NtlmHttpURLConnection spiedConnection = spy(ntlmConnection);
        doNothing().when(spiedConnection).connect();
        // Mock the handshake process to do nothing complex
        mockResponse(HTTP_OK, "OK", null, null);

        // Act & Assert
        assertDoesNotThrow(() -> spiedConnection.getResponseCode());
        // Use reflection to verify handshake method is called