- commit
  - comment_added

automations:

  # If a PR is very complex, require 2 approvals
  complex_changes:
    if:
      - {{ ('complex_changes' | isEnabledAutomation(pr)) }}
      - {{ branch | estimatedReviewTime >= 40 }}
      - {{ files | length >= 35 }}
      - {{ includes_src_changes }}
    run:
      - action: set-required-approvals@v1
        args:
          approvals: 2

things you should know about contributing:

1.  API changes require discussion, use cases, etc. Code comes later.
2.  Pull requests are great for small fixes for bugs, documentation, etc.
3.  Pull requests are not merged directly into the master branch.
4.  Code contributions require signing a Google CLA.

API changes
-----------

We make changes to Guava's public [APIs][], including adding new APIs, very

If `values.yaml` is changed, be sure to update corresponding values changes in [../profiles/default.yaml](../profiles/default.yaml)

## Step 3. Update istioctl schema

Istioctl uses a [schema](../../operator/pkg/apis/istio/v1alpha1/values_types.proto) to validate the values. Any changes to
the schema must be added here, otherwise istioctl users will see errors.

2. Accept the changes.\
If you are sure that the changes are intentional, follow the steps described in the report.
This includes adding the description of the changes to the `accepted-public-api-changes.json` file, and providing a reason for each change.
You can add the changes to any place in the file, e.g. at the top.

3. Make sure the file with accepted changes is sorted.\

    changes to be made to PR to pass quality checks and send it back or on a
    rare occasion we may reject it.

**3. Review**

-   For a valid PR, reviewer (person familiar with the code/functionality)
    checks if the PR looks good or needs additional changes.
-   If all looks good, the reviewer will approve the PR.
-   If a change is needed, the contributor is requested to make the suggested

  - [Changes since v1.2.3](#changes-since-v123)
    - [Other notable changes](#other-notable-changes-3)
- [v1.2.3](#v123)
  - [Downloads for v1.2.3](#downloads-for-v123)
  - [Changes since v1.2.2](#changes-since-v122)
    - [Action Required](#action-required)
    - [Other notable changes](#other-notable-changes-4)
- [v1.2.2](#v122)
  - [Downloads for v1.2.2](#downloads-for-v122)
  - [Changes since v1.2.1](#changes-since-v121)

    private
    fun buildErrorMessage(formattedMismatches: String): String {
        return "API changes in file '${apiChangesFile.get().asFile.name}' should be in alphabetical order (by type and member), yet these changes were not:\n" +
            "$formattedMismatches\n" +
            "\n" +
            "To automatically alphabetize these changes run: 'gradlew :architecture-test:sortAcceptedApiChanges'"
    }

One week before a release, the release branch goes into a state of code freeze. At this point only critical release
blocking bugs are addressed. Additional changes that are targeted for new features and capabilities will not be merged.

## Features requiring API changes

If a PR change requires an API change
* Updates to documentation do not require explicit approval from the Technical Oversight Committee (TOC). This can be

    protected
    fun assertHasMisorderedChanges(changes: List<Change>? = null) {
        val standardError = StringWriter()
        run(":verifyAcceptedApiChangesOrdering")
            .forwardStdError(standardError)
            .buildAndFail()

        val expectedOutput = "API changes in file '${acceptedApiChangesFile.name}' should be in alphabetical order (by type and member), yet these changes were not:\n"

FastAPI also follows the convention that any "PATCH" version change is for bug fixes and non-breaking changes.

!!! tip
    The "PATCH" is the last number, for example, in `0.2.3`, the PATCH version is `3`.

So, you should be able to pin to a version like:

```txt
fastapi>=0.45.0,<0.46.0
```

Breaking changes and new features are added in "MINOR" versions.