tagLabel := hook.GetLabels()[label.IoIstioTag.Name]
		ri, revPresent := revisions[rev]
		if revPresent {
			if tagLabel != "" {
				ri.Webhooks = append(ri.Webhooks, &MutatingWebhookConfigInfo{
					Name:     hook.Name,
					Revision: rev,
					Tag:      tagLabel,
				})
			}
		} else {
			revisions[rev] = &RevisionDescription{
				IstioOperatorCRs: []*IstioOperatorCRInfo{},

  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
  <modelVersion>4.0.0</modelVersion>
  <groupId>com.example.group</groupId>
  <artifactId>valid-version-revision</artifactId>
  <version>${revision}</version>

  <description>
    This will test if the validation for the ci friendly versions
    is working correct.
  </description>

type ControlPlaneOptions struct {
	// Revision is the istio.io/rev control plane revision
	Revision string
}

// AttachControlPlaneFlags attaches control-plane flags to a Cobra command.
// (Currently just --revision)
func (o *ControlPlaneOptions) AttachControlPlaneFlags(cmd *cobra.Command) {
	cmd.PersistentFlags().StringVarP(&o.Revision, "revision", "r", "",
		"Control plane revision")

	tcs := []struct {
		name          string
		tag           string
		revision      string
		webhookBefore *admitv1.MutatingWebhookConfiguration
		outputMatches []string
		error         string
	}{
		{
			name:          "TestErrorWhenRevisionWithNameCollision",
			tag:           "revision",
			revision:      "revision",
			webhookBefore: &revisionCanonicalWebhook,
			outputMatches: []string{},

	return wh.ObjectMeta.Labels[label.IoIstioTag.Name]
}

// GetWebhookRevision extracts tag target revision from webhook object.
func GetWebhookRevision(wh admitv1.MutatingWebhookConfiguration) (string, error) {
	if tagName, ok := wh.ObjectMeta.Labels[label.IoIstioRev.Name]; ok {
		return tagName, nil
	}
	return "", fmt.Errorf("could not extract tag revision from webhook")
}

// DeleteTagWebhooks deletes the given webhooks.

)

type testCase struct {
	version        string
	revision       string
	expectedOutput diag.Messages
	expectedError  error
}

func Test_checkFromVersion(t *testing.T) {
	cases := []testCase{
		{
			revision:       "canary",
			version:        "1.21",
			expectedOutput: diag.Messages{},
			expectedError:  nil,
		},
		{
			revision:       "canary",
			version:        "XX",
			expectedOutput: nil,

}

type instance struct {
	// clients are cached clients for each revision
	clients map[string]kube.CLIClient
	// remoteClients are cached clients for each context with empty revision.
	remoteClients map[string]kube.CLIClient
	RootFlags
}

func newKubeClientWithRevision(kubeconfig, configContext, revision string, impersonateConfig rest.ImpersonationConfig) (kube.CLIClient, error) {

			args:          strings.Split("random-gibberish-podname-61789237418234", " "),
			wantException: true,
		},
		{ // case 6: new --revision argument
			args:           strings.Split("--revision canary", " "),
			expectedString: "NAME     CLUSTER     CDS     LDS     EDS     RDS     ECDS     ISTIOD",
			revision:       "canary",
		},
		{ // case 7: supplying type that doesn't select pods should fail

                    "patch": 3
                },
                "metadata": {
                        "build.type": "RELEASE",
                        "revision.sha": "436f365a8007cd8a13a9f1321e7cce94bcc8883e",
                        "revision.status": "Clean",
                        "ssl.version": "BoringSSL"
                    }
            }
        }
    }

              "minorNumber": 18,
              "patch": 3
            },
            "metadata": {
              "build.type": "RELEASE",
              "revision.sha": "436f365a8007cd8a13a9f1321e7cce94bcc8883e",
              "revision.status": "Clean",
              "ssl.version": "BoringSSL"
            }
          }
        }
      }
    }
  ]